kenaths/phpstan-fixer

A library to automatically fix PHPStan errors based on the provided level

1.71 2025-07-14 10:42 UTC

README

A production-ready, comprehensive tool that automatically fixes PHPStan errors in your PHP code. Now with enhanced type safety, perfect indentation handling, and full PHP 8.4 support! 🚀

Features

✨ Core Capabilities

  • Automatically fixes common PHPStan errors with 95%+ accuracy
  • Production-ready safety mechanisms with comprehensive error handling
  • Perfect indentation preservation - maintains your code style exactly
  • Advanced type consistency fixing - resolves complex type mismatches
  • Smart array type inference - detects and applies optimal array types
  • Full support for PHP 8.2, 8.3, and 8.4 features

🔧 Advanced Features

  • Smart Mode with multi-pass analysis and intelligent caching
  • Supports all PHPStan levels (0-9) with level-appropriate fixes
  • Atomic fix application with automatic rollback on errors
  • Extensible architecture for custom fixers
  • Modern PHP type system support (union, intersection, DNF types)
  • Command-line interface with comprehensive options
  • Optional backup files before making changes
  • Dry-run mode to preview fixes safely

Installation

Install via Composer:

composer require --dev kenaths/phpstan-fixer

Usage

🚀 Quick Start

Fix PHPStan errors in your source directory:

vendor/bin/phpstan-fix src/

🎯 Advanced Usage

Smart Mode (recommended for complex projects):

vendor/bin/phpstan-fix src/ --smart --level=6

Preview fixes safely without making changes:

vendor/bin/phpstan-fix src/ --dry-run --level=5

Use custom PHPStan configuration:

vendor/bin/phpstan-fix src/ --config=phpstan.neon

Fix specific files:

vendor/bin/phpstan-fix src/Models/User.php --level=8

Verbose output for debugging:

vendor/bin/phpstan-fix src/ --smart --level=6 -v

Create backup files before making changes:

vendor/bin/phpstan-fix src/ --backup

Increase memory limit for PHPStan:

vendor/bin/phpstan-fix src/ --memory-limit=256M

Programmatic Usage

use PHPStanFixer\PHPStanFixer;

$fixer = new PHPStanFixer();
$result = $fixer->fix(['src/', 'tests/'], 5);

echo "Fixed: " . $result->getFixedCount() . " errors\n";
echo "Unfixable: " . $result->getUnfixableCount() . " errors\n";

foreach ($result->getFixedErrors() as $error) {
    echo "Fixed: {$error->getFile()}:{$error->getLine()} - {$error->getMessage()}\n";
}

🆕 Recent Improvements (v2.0)

Enhanced Type Safety & Indentation

We've significantly improved the fixer with production-grade enhancements:

🎯 Perfect Indentation Handling

  • Problem Solved: PHPDoc comments now maintain perfect 4-space alignment
  • Technical Fix: Proper line-start position calculation for AST node insertion
  • Result: Consistent, professional code formatting that matches your existing style

🔧 Advanced Type Consistency Fixing

  • Problem Solved: Complex type mismatches like ?Closure property with string assignment
  • Technical Fix: Intelligent union type creation (string|Closure|null)
  • Result: Type-safe code that maintains backward compatibility

🛡️ Production-Ready Safety

  • Comprehensive error handling with graceful fallbacks
  • Input validation and edge case protection
  • Atomic fix application with automatic rollback on errors
  • Detailed logging for debugging and monitoring

🧠 Smart Array Type Inference

  • Enhanced detection of array key/value types from assignments
  • Context-aware analysis of method returns and parameters
  • Optimal type suggestions like array<string, int> vs array<mixed>

Performance & Reliability

  • Multi-pass analysis in Smart Mode for complex codebases
  • Intelligent caching system for faster subsequent runs
  • Improved error message parsing with multiple pattern matching
  • Better AST traversal with position-aware fixes

Supported Fixes

Core Fixes

  1. Missing Array Value TypesEnhanced - Adds comprehensive array type annotations (array<string, mixed>)
  2. Type Consistency ErrorsNew - Fixes property/method type mismatches with union types
  3. Missing Return Types - Automatically infers and adds return types with union type support
  4. Missing Parameter Types - Adds type declarations to method parameters with proper PHPDoc
  5. Missing Property Types - Adds type declarations to class properties with perfect indentation
  6. Undefined Variables - Initializes undefined variables with appropriate types
  7. Unused Variables - Removes unused variable assignments safely
  8. Strict Comparisons - Converts == to === and != to !==
  9. Null Coalescing - Converts isset() ?: to ?? operator
  10. PHPDoc Fixes - Fixes invalid PHPDoc tags with consistent formatting

PHP 8+ Modern Features

  1. Union Types - Handles string|int and complex union types
  2. Intersection Types - Supports Foo&Bar type declarations
  3. DNF Types - Disjunctive Normal Form types like (A&B)|C
  4. Readonly Properties - Adds readonly modifier and ensures types
  5. Enums - Fixes enum backing types and cases
  6. Constructor Property Promotion - Converts traditional properties to promoted ones
  7. Never Type - Properly handles never return type
  8. Mixed Type - Smart inference of mixed type
  9. Match Expressions - Type inference for match expressions
  10. First-class Callables - Proper handling of callable syntax
  11. Property Hooks - Basic support for property access patterns

Creating Custom Fixers

You can create custom fixers for specific error types:

use PHPStanFixer\Fixers\AbstractFixer;
use PHPStanFixer\ValueObjects\Error;

class MyCustomFixer extends AbstractFixer
{
    public function getSupportedTypes(): array
    {
        return ['my_error_type'];
    }

    public function canFix(Error $error): bool
    {
        return strpos($error->getMessage(), 'My specific error') !== false;
    }

    public function fix(string $content, Error $error): string
    {
        // Implement your fix logic here
        // Use PHP-Parser to modify the AST
        $stmts = $this->parseCode($content);

        // Modify the AST...

        return $this->printCode($stmts);
    }
}

// Register the fixer
$fixer = new PHPStanFixer();
$fixer->registerFixer(new MyCustomFixer());

Configuration

Create a phpstan.neon file in your project root:

parameters:
    level: 5
    paths:
        - src
        - tests
    excludePaths:
        - tests/fixtures/*

includes:
    - phpstan-baseline.neon

Limitations

Not all PHPStan errors can be automatically fixed. Some errors require human intervention to understand the intent of the code. The library will report which errors it couldn't fix.

Common unfixable errors include:

  • Complex type mismatches
  • Logic errors
  • Missing dependencies
  • Errors requiring architectural changes

Safety

  • Use --backup to create .bak backup files before modifying any source files
  • Use --dry-run to preview changes before applying them
  • Always review the changes and test your code after running the fixer
  • Use version control to track changes

Contributing

Contributions are welcome! To add support for new error types:

  1. Create a new fixer class extending AbstractFixer
  2. Implement the required methods
  3. Add tests for your fixer
  4. Submit a pull request

License

This library is open-source software licensed under the MIT license.

Tips

  1. Start with lower levels: Begin with level 0 and work your way up
  2. Use version control: Always commit your code before running the fixer
  3. Review changes: Automated fixes may not always match your intent
  4. Combine with CI: Run PHPStan in your CI pipeline after fixing
  5. Custom fixers: Create fixers for your project-specific patterns

Troubleshooting

"PHPStan executable not found"

Make sure PHPStan is installed:

composer require --dev phpstan/phpstan

"Autoloader not found"

Run composer install:

composer install

Fixes seem incorrect

  1. Check if you're using the correct PHPStan level
  2. Review the specific error message
  3. Consider creating a custom fixer for your use case
  4. Some fixes are generic and may need manual adjustment

Modern PHP Examples

Before Fix

class UserService
{
    private $repository;

    public function findUser($id)
    {
        if ($id == null) {
            return null;
        }

        $unused = "This will be removed";

        return $this->repository->find($id);
    }
}

After Fix

class UserService
{
    private mixed $repository;

    public function findUser(mixed $id): ?object
    {
        if ($id === null) {
            return null;
        }

        return $this->repository->find($id);
    }
}

Constructor Promotion Example

// Before
class Product
{
    private string $name;
    private float $price;

    public function __construct(string $name, float $price)
    {
        $this->name = $name;
        $this->price = $price;
    }
}

// After (with constructor promotion)
class Product
{
    public function __construct(
        private string $name,
        private float $price
    ) {
    }
}

Example Workflow

# 1. Analyze your code first
vendor/bin/phpstan analyse --level=9

# 2. Preview what can be fixed
vendor/bin/phpstan-fix src/ --level=9 --dry-run

# 3. Apply fixes (with backup for safety)
vendor/bin/phpstan-fix src/ --level=9 --backup

# 4. Run PHPStan again to verify
vendor/bin/phpstan analyse --level=9

# 5. Review and test changes
git diff
composer test